SuppressedAssociatedTypesWithDefaults: make scoping pay attention to root #86080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@swift-ci smoke test macOS |
The generic parameter at the root of a DependentMemberType is the main thing we care about in terms of the scoping rule. We have a check for ineffective / invalid inverses in a later phase, so if the suppression on the type member was wrong then we should still raise an error about it.
kavon
force-pushed
the
suppressed-assoc-types-with-defaults-3
branch
from
f6f8f11 to
fbd51c0
Compare
Member
Author
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scoping rule with
SuppressedAssociatedTypes*is too eagerly complaining about invalid scopes. We'll diagnose invalid suppressions anyway in that case.